[
https://issues.apache.org/jira/browse/GOBBLIN-1114?focusedWorklogId=420867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420867
]
ASF GitHub Bot logged work on GOBBLIN-1114:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/20 02:00
Start Date: 12/Apr/20 02:00
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2954: [GOBBLIN-1114]
OrcValueMapper schema evolution up-conversion recursive
URL: https://github.com/apache/incubator-gobblin/pull/2954#discussion_r407133543
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcValueMapper.java
##########
@@ -91,7 +113,9 @@ OrcStruct upConvertOrcStruct(OrcStruct orcStruct, Context
context) {
TypeDescription readerType = newSchemaTypes.get(indexInNewSchema);
if (isEvolutionValid(fileType, readerType)) {
Review comment:
Should isEvolutionValid() be inside a utils class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 420867)
Time Spent: 1h 40m (was: 1.5h)
> ORC-mapred schema evolution enhancement
> ---------------------------------------
>
> Key: GOBBLIN-1114
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1114
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
