autumnust commented on a change in pull request #2956: GOBBLIN-1116: Avoid registering schema with schema registry during Me… URL: https://github.com/apache/incubator-gobblin/pull/2956#discussion_r409154299
########## File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/metrics/reporter/util/SchemaRegistryVersionWriter.java ########## @@ -26,11 +26,14 @@ import org.apache.commons.codec.DecoderException; import org.apache.commons.codec.binary.Hex; -import com.google.common.base.Optional; +import com.google.common.base.Strings; import com.google.common.base.Throwables; import com.google.common.collect.Maps; import com.typesafe.config.Config; +import javax.annotation.Nullable; Review comment: is this the right Nullable that you want ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
