[
https://issues.apache.org/jira/browse/GOBBLIN-1120?focusedWorklogId=424455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424455
]
ASF GitHub Bot logged work on GOBBLIN-1120:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 22:09
Start Date: 17/Apr/20 22:09
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2960: GOBBLIN-1120:
Reinitialize HelixManager when Helix participant check …
URL: https://github.com/apache/incubator-gobblin/pull/2960#discussion_r410493555
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheck.java
##########
@@ -52,6 +53,8 @@
@Slf4j
@Alias (value = "HelixParticipantCheck")
public class HelixAssignedParticipantCheck implements CommitStep {
+ @Getter
+ @VisibleForTesting
Review comment:
The variable is accessible via Getter in the Test class. The annotation is
to indicate that the Getter is added for access inside the test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 424455)
Time Spent: 40m (was: 0.5h)
> Reinitialize HelixManager when Helix participant check throws an exception
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1120
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1120
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When the underlying ZkClient is closed, Helix participant check throws:
> Caused by: java.lang.IllegalStateException: ZkClient already closed!
> In these cases, the HelixManager instance used to do the participant check
> needs to be re-initialized to obtain a new ZKClient.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
