sv2000 commented on a change in pull request #2961:
URL: https://github.com/apache/incubator-gobblin/pull/2961#discussion_r411772456



##########
File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnContainerSecurityManagerForApplicationMaster.java
##########
@@ -0,0 +1,29 @@
+package org.apache.gobblin.yarn;
+
+import com.google.common.base.Throwables;
+import com.google.common.eventbus.EventBus;
+import com.typesafe.config.Config;
+import java.io.IOException;
+import org.apache.gobblin.yarn.event.DelegationTokenUpdatedEvent;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
+
+public class YarnContainerSecurityManagerForApplicationMaster extends 
YarnContainerSecurityManager{

Review comment:
       Rename to YarnAppMasterSecurityManager. 

##########
File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnContainerSecurityManagerForApplicationMaster.java
##########
@@ -0,0 +1,29 @@
+package org.apache.gobblin.yarn;

Review comment:
       Missing the Apache Header.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to