sv2000 commented on a change in pull request #2967:
URL: https://github.com/apache/incubator-gobblin/pull/2967#discussion_r415515266
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
##########
@@ -309,9 +322,22 @@ public void start() {
// Start metric reporting
if (this.containerMetrics.isPresent()) {
- this.containerMetrics.get()
-
.startMetricReportingWithFileSuffix(ConfigUtils.configToState(this.clusterConfig),
- this.taskRunnerId);
+ try {
+ this.containerMetrics.get()
+
.startMetricReportingWithFileSuffix(ConfigUtils.configToState(this.clusterConfig),
this.taskRunnerId);
+ } catch (MetricReporterException e) {
+ logger.error("Failed to start {} metric reporter", e.getType().name(),
e);
+ if (this.isMetricReportingFailureFatal) {
+ logger.error("Failing TaskRunner since metric reporting failure is
FATAL.");
+ Throwables.propagate(e);
Review comment:
Addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
