[
https://issues.apache.org/jira/browse/GOBBLIN-1132?focusedWorklogId=427995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427995
]
ASF GitHub Bot logged work on GOBBLIN-1132:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/20 06:21
Start Date: 28/Apr/20 06:21
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#2969:
URL: https://github.com/apache/incubator-gobblin/pull/2969#discussion_r416356645
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsResource.java
##########
@@ -140,7 +139,7 @@ public UpdateResponse delete(ComplexResourceKey<FlowId,
EmptyRecord> key) {
* @param originalFlowConfig original flow config to find original requester
* @param requesterList list of requesters for this request
*/
- public static void checkRequester(FlowConfig originalFlowConfig,
List<ServiceRequester> requesterList) {
Review comment:
Had to change it, coz using non static object (this.requesterService)
inside.
Will work actively towards removing V1 completely
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 427995)
Time Spent: 50m (was: 40m)
> move logic of requester list validation to RequesterService implementation
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1132
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1132
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
