[
https://issues.apache.org/jira/browse/GOBBLIN-1135?focusedWorklogId=429312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429312
]
ASF GitHub Bot logged work on GOBBLIN-1135:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/20 23:53
Start Date: 30/Apr/20 23:53
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#2974:
URL: https://github.com/apache/incubator-gobblin/pull/2974#discussion_r418352329
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_executorInstance/AbstractSpecExecutor.java
##########
@@ -182,7 +183,7 @@ public int hashCode() {
abstract protected void shutDown() throws Exception;
- abstract public Future<? extends SpecProducer> getProducer();
+ abstract public Future<? extends SpecProducer<Spec>> getProducer();
Review comment:
I don't think so. We are actually not serializing/deserializing
SpecProducer. We serialize/deserialize SpecExecutor and then find the producer
from a mapping. After finding a producer we serialize/deserialize the onSpecAdd
response Future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429312)
Time Spent: 20m (was: 10m)
> flow remove feature for spec executors when dag manager is not enabled
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1135
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1135
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
