[
https://issues.apache.org/jira/browse/GOBBLIN-1133?focusedWorklogId=429613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429613
]
ASF GitHub Bot logged work on GOBBLIN-1133:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 18:53
Start Date: 01/May/20 18:53
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #2973:
URL:
https://github.com/apache/incubator-gobblin/pull/2973#issuecomment-622515344
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=h1)
Report
> Merging
[#2973](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/cc50c491cc40789300ad3019999cfa23f0027724&el=desc)
will **decrease** coverage by `0.93%`.
> The diff coverage is `61.11%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2973 +/- ##
============================================
- Coverage 45.63% 44.69% -0.94%
+ Complexity 9196 9029 -167
============================================
Files 1940 1942 +2
Lines 73574 73646 +72
Branches 8128 8131 +3
============================================
- Hits 33574 32916 -658
- Misses 36873 37647 +774
+ Partials 3127 3083 -44
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...actionSuiteBaseWithConfigurableCompleteAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZVdpdGhDb25maWd1cmFibGVDb21wbGV0ZUFjdGlvbi5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...uiteBaseWithConfigurableCompleteActionFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZVdpdGhDb25maWd1cmFibGVDb21wbGV0ZUFjdGlvbkZhY3RvcnkuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...che/gobblin/yarn/YarnContainerSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkNvbnRhaW5lclNlY3VyaXR5TWFuYWdlci5qYXZh)
| `60.86% <0.00%> (-2.77%)` | `5.00 <0.00> (ø)` | |
|
[.../action/CompactionCompleteFileOperationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25Db21wbGV0ZUZpbGVPcGVyYXRpb25BY3Rpb24uamF2YQ==)
| `70.66% <81.81%> (+7.17%)` | `6.00 <2.00> (+1.00)` | |
|
[...ompaction/mapreduce/CompactionJobConfigurator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL0NvbXBhY3Rpb25Kb2JDb25maWd1cmF0b3IuamF2YQ==)
| `69.17% <100.00%> (+1.20%)` | `25.00 <1.00> (+2.00)` | |
|
[.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh)
| `100.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh)
| `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [54
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2973/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=footer).
Last update
[cc50c49...5d84835](https://codecov.io/gh/apache/incubator-gobblin/pull/2973?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429613)
Time Spent: 40m (was: 0.5h)
> Add CompactionSuiteBaseWithConfigurableCompleteAction to make complete action
> configurable
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1133
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1133
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> # Add CompactionSuiteBaseWithConfigurableCompleteAction to make complete
> action configurable
> # Include dstNewFiles and oldFiles in CompactionJobConfigurator
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
