[GitHub] [incubator-gobblin] yukuai518 commented on a change in pull request #2977: [GOBBLIN-1141] add support for common job properties in helix job scheduler

[GitBox]

yukuai518 commented on a change in pull request #2977:
URL: https://github.com/apache/incubator-gobblin/pull/2977#discussion_r419599055



##########
File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -109,16 +110,16 @@
   private boolean startServicesCompleted;
   private final long helixJobStopTimeoutMillis;
 
-  public GobblinHelixJobScheduler(Properties properties,
+  public GobblinHelixJobScheduler(Config configs,

Review comment:
       configs => sysConfig?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org