[ 
https://issues.apache.org/jira/browse/GOBBLIN-1141?focusedWorklogId=430312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430312
 ]

ASF GitHub Bot logged work on GOBBLIN-1141:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/20 17:23
            Start Date: 04/May/20 17:23
    Worklog Time Spent: 10m 
      Work Description: yukuai518 commented on a change in pull request #2977:
URL: https://github.com/apache/incubator-gobblin/pull/2977#discussion_r419599055



##########
File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -109,16 +110,16 @@
   private boolean startServicesCompleted;
   private final long helixJobStopTimeoutMillis;
 
-  public GobblinHelixJobScheduler(Properties properties,
+  public GobblinHelixJobScheduler(Config configs,

Review comment:
       configs => sysConfig?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 430312)
    Time Spent: 20m  (was: 10m)

> provide an option for common configs in cluster
> -----------------------------------------------
>
>                 Key: GOBBLIN-1141
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1141
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to