arjun4084346 commented on a change in pull request #2979: URL: https://github.com/apache/incubator-gobblin/pull/2979#discussion_r421269048
########## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/predicates/TableTypeFilter.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.data.management.copy.predicates; + +import java.util.Properties; + +import org.apache.hadoop.hive.metastore.api.Table; + +import com.google.common.base.Predicate; + +import javax.annotation.Nullable; + + +/** + * A predicate to check if a hive {@link Table} is of a certain type in {@link TABLE_TYPE} + * + * <p> Example usage: {@link org.apache.gobblin.data.management.copy.hive.HiveDatasetFinder#TABLE_FILTER} + */ +public class TableTypeFilter implements Predicate<Table> { + + public static final String FILTER_TYPE = "tableTypeFilter.type"; + + private enum TABLE_TYPE { + SNAPSHOT, + PARTITIONED + } + + private final TABLE_TYPE tableType; + + public TableTypeFilter(Properties props) { + tableType = TABLE_TYPE.valueOf( + props.getProperty(FILTER_TYPE, TABLE_TYPE.SNAPSHOT.name()).toUpperCase()); + } + + @Override + public boolean apply(@Nullable Table input) { + if (input == null) { + return false; + } + + switch (tableType) { + case SNAPSHOT: + return input.getPartitionKeys() == null || input.getPartitionKeys().size() == 0; + case PARTITIONED: + return input.getPartitionKeys() != null && input.getPartitionKeys().size() > 0; + } Review comment: I was not comfortable with this and then why I googled, I found `switch-case` without a `default` is widely not recommended. https://help.semmle.com/wiki/display/JAVA/Missing+default+case+in+switch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
