[ 
https://issues.apache.org/jira/browse/GOBBLIN-1154?focusedWorklogId=436224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436224
 ]

ASF GitHub Bot logged work on GOBBLIN-1154:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/20 21:53
            Start Date: 21/May/20 21:53
    Worklog Time Spent: 10m 
      Work Description: jack-moseley commented on a change in pull request 
#2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r428936777



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java
##########
@@ -81,7 +83,7 @@ public CreateKVResponse createFlowConfig(FlowConfig 
flowConfig, boolean triggerL
     } else if 
(Boolean.parseBoolean(responseMap.getOrDefault(ServiceConfigKeys.COMPILATION_SUCCESSFUL,
 new AddSpecResponse<>("false")).getValue().toString())) {
       httpStatus = HttpStatus.S_201_CREATED;
     } else {
-      httpStatus = HttpStatus.S_400_BAD_REQUEST;
+      throw new RestLiServiceException(HttpStatus.S_400_BAD_REQUEST, "Flow was 
not compiled successfully");

Review comment:
       The challenge is that if a flow doesn't compile it's hard to know why 
because we don't know what was the intended path. It could be because of 
missing edges/nodes, or unresolved config keys. It's something that could be 
improved upon still, but most users of gaas self-serve should be using edges 
we've already defined so probably shouldn't have this problem anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 436224)
    Time Spent: 1h 20m  (was: 1h 10m)

> Improve gaas error messages
> ---------------------------
>
>                 Key: GOBBLIN-1154
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1154
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to