vikrambohra commented on a change in pull request #2998:
URL: https://github.com/apache/incubator-gobblin/pull/2998#discussion_r430612383
##########
File path: gobblin-binary-management/build.gradle
##########
@@ -25,9 +25,9 @@ dependencies {
compile externalDependency.avroMapredH2
compile externalDependency.guava
compile externalDependency.hadoopHdfs
- runtime externalDependency.hadoopCommon
- runtime externalDependency.hadoopClientCore
- runtime externalDependency.hadoopAuth
+ runtimeOnly externalDependency.hadoopCommon
Review comment:
so, those dependencies where "runtime" before I changed it to
"runtimeOnly" because maven-publish wasn't mapping them into the pom file.
RuntimeOnly is an extension of runtime configuration and maven-publish plugin
maps it correct "runtime" scope.
Not sure why we need to change it to "implementation"
Reference:
https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management
##########
File path: .travis.yml
##########
@@ -42,6 +43,9 @@ env:
- RUN_TEST_GROUP=default
- RUN_TEST_GROUP=group1
- RUN_TEST_GROUP=coverage
+ global:
+ - secure:
f7aIQDgpWHIkYf19mtViOLwH/zBAeVuqOQtu9G4cfDl6R+lqYbTuSEA+HyP2EzT9E7w2bPdVRuwUEb3/FFCBcHTjSBiQ+Nnhtto1RvoXjYlzV9ImG/5s4dsYsrUGWyWxoWXHNRFLE8Xeq4pe6lHR/Md+MajuxdBxgd8AFefMvTEW7a9h8cc+w+kEkKZ9msyiJTzxiTy7d9Yob6bNOEfhTAIUk5jK+a9qqYjDILaps75Y6BMcI3fQZyZno3+/8KBNhk7ncQKf4voRwmQRcAaVM0isQ2kUW4MIRykXRQT3zZJcXxYUoNThn0T9RydjzSu14EM5iNY9IdJVTsojihI/Fvfac9K24UAV5d/k8vlrnTJ4feJfDR1LoHNtCa72U8/cuEKFu2WoJg+kmukcW3pOAshRVLaZw7eCUMS+HevG1uG2wLISN3lAyVoqJCyvu+HaoD1wWfnwfxdZxUXDi+T+Pv7niqVshXMRF8lRQ3+Xf52b40+xhJ78SUWDQgAfClQrJ52o8xEnGOskBAoaJGLlChPMFWhbgHZ8f0cRKPrW/+Q8KGkrcyoo/yxauMkdkiXmg2h0ebNZSfgRc4gn79mU0BKjmsZPKw9RqifGijjAfc0zPplMJMle0hplnuX0QvFALA0go2LInTCvYofk+PU/BMlDHCHJVEBiAarMXv/8P0w=
Review comment:
https://issues.apache.org/jira/browse/INFRA-20327
##########
File path: gradle.properties
##########
@@ -21,7 +21,7 @@ org.gradle.daemon=true
# Configures only relevant projects to speed up the configuration of large
projects
# Useful when specific project/task is invoked
-org.gradle.configureondemand=true
+org.gradle.configureondemand=false
Review comment:
thank for catching this.
##########
File path: gobblin-rest-service/gobblin-rest-api/build.gradle
##########
@@ -112,6 +112,67 @@ artifacts {
archives dataTemplateSourcesJar, dataTemplateJavadocJar,
restClientSourcesJar, restClientJavadocJar
}
+publishing {
+ publications {
+ dataTemplate(MavenPublication) {
+ //from components.java
+ artifactId dataTemplateName
+ artifacts = [artifact(tasks.mainDataTemplateJar),
dataTemplateSourcesJar, dataTemplateJavadocJar]
+ pom pomAttributes
+ pom.withXml {
+ def dependenciesNode = asNode().appendNode('dependencies')
+
+ configurations.runtime.allDependencies.each {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
