[
https://issues.apache.org/jira/browse/GOBBLIN-1162?focusedWorklogId=438937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438937
]
ASF GitHub Bot logged work on GOBBLIN-1162:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 20:50
Start Date: 29/May/20 20:50
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3002:
URL: https://github.com/apache/incubator-gobblin/pull/3002#discussion_r432728669
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/commit/NoopCommitStep.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.commit;
+
+import java.io.IOException;
+
+
+/**
+ * A no-op implementation of {@link CommitStep}.
+ */
+public class NoopCommitStep implements CommitStep {
Review comment:
I had added it for testing. Removed it. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 438937)
Time Spent: 0.5h (was: 20m)
> Provide an option to allow slow containers to commit suicide when unhealthy
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1162
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1162
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In execution environments such as Gobblin-on-Yarn, where Gobblin workers can
> be re-assigned when the worker dies or is killed, it is useful to add a mode
> where each Gobblin task running inside a Gobblin worker can perform
> application-level health checks and report results of the health checks back
> to the worker hosting the tasks. The worker on receiving a health check
> failure event can be configured to exit the JVM. In the case of
> Gobblin-on-Yarn mode, this will result in the worker getting re-assigned to a
> different node. The proposed behavior is similar in flavor to speculative
> execution modes provided in other execution frameworks such as MapReduce.
> This change also provides an example of such an application-level health
> check that arises in the case of Kafka ingestion.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
