[
https://issues.apache.org/jira/browse/GOBBLIN-1168?focusedWorklogId=439126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439126
]
ASF GitHub Bot logged work on GOBBLIN-1168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/20 18:53
Start Date: 30/May/20 18:53
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3001:
URL: https://github.com/apache/incubator-gobblin/pull/3001#discussion_r432878416
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java
##########
@@ -358,4 +361,50 @@ public URI getUri() {
public Boolean isExplain() {
return ConfigUtils.getBoolean(getConfig(),
ConfigurationKeys.FLOW_EXPLAIN_KEY, false);
}
+
+ @Slf4j
+ public static class Utils {
Review comment:
a separate util class is preferred over util methods, to keep util
methods cleanly separate.
a nested util class instead of an outer class is just a coding style
preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 439126)
Time Spent: 0.5h (was: 20m)
> create InstrumentedSpecStore
> ----------------------------
>
> Key: GOBBLIN-1168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> create InstrumentedSpecStore to add metrics in all SpecStore implementations
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
