[
https://issues.apache.org/jira/browse/GOBBLIN-1180?focusedWorklogId=441013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441013
]
ASF GitHub Bot logged work on GOBBLIN-1180:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/20 22:43
Start Date: 03/Jun/20 22:43
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3026:
URL:
https://github.com/apache/incubator-gobblin/pull/3026#issuecomment-638447161
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=h1)
Report
> Merging
[#3026](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/469a56d9161c404c6dc73e8fe927fe2bb8922ddd&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3026 +/- ##
=========================================
Coverage 45.72% 45.72%
+ Complexity 9295 9292 -3
=========================================
Files 1951 1951
Lines 74255 74255
Branches 8218 8218
=========================================
Hits 33953 33953
+ Misses 37129 37127 -2
- Partials 3173 3175 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3026/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| `43.68% <0.00%> (-3.89%)` | `10.00% <0.00%> (-2.00%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3026/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `62.70% <0.00%> (-0.34%)` | `33.00% <0.00%> (ø%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3026/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0.00%> (+2.22%)` | `13.00% <0.00%> (ø%)` | |
|
[...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3026/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=)
| `63.95% <0.00%> (+3.48%)` | `12.00% <0.00%> (ø%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=footer).
Last update
[469a56d...b11ce92](https://codecov.io/gh/apache/incubator-gobblin/pull/3026?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 441013)
Time Spent: 1h (was: 50m)
> Remove dependency on gobblin-parquet
> ------------------------------------
>
> Key: GOBBLIN-1180
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1180
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> gobblin-parquet has dependencies on com.twitter parquet libraries.
> 'com.twitter:parquet-protobuf:1.5.0' (including higher versions) is not
> resolvable from MavenCentral because it's missing some of its transitive
> dependencies. This makes the 'gobblin-parquet' module _also not resolvable_
> from MavenCentral (e.g. 'org.apache.gobblin:gobblin-parquet:0.14.0' does not
> resolve from Central as of today).
> To fix this, I suggest using "gobblin-parquet-apache" (which has org.apache
> parquet libraries) instead of "gobblin-parquet"
> This also unblocks automated consumption of gobblin external artifact at
> LinkedIn
> After this change, gobblin-parquet module can safely be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
