[ 
https://issues.apache.org/jira/browse/GOBBLIN-1178?focusedWorklogId=441025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441025
 ]

ASF GitHub Bot logged work on GOBBLIN-1178:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/20 23:35
            Start Date: 03/Jun/20 23:35
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on a change in pull request #3024:
URL: https://github.com/apache/incubator-gobblin/pull/3024#discussion_r434911632



##########
File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -413,6 +424,10 @@ private boolean taskSuccessfulInPriorAttempt(String 
taskId) {
         }
 
         if (task == null) {
+          if (e instanceof RetryException) {
+            // Indicating task being null due to failure in creation even 
after retrying.
+            failureInTaskCreation = false;

Review comment:
       failureInTaskCreation -> isTaskCreatedSuccessfully? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 441025)
    Time Spent: 50m  (was: 40m)

> Propagate task creation failure to Helix 
> -----------------------------------------
>
>                 Key: GOBBLIN-1178
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1178
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to