[
https://issues.apache.org/jira/browse/GOBBLIN-1181?focusedWorklogId=441421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441421
]
ASF GitHub Bot logged work on GOBBLIN-1181:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/20 17:09
Start Date: 04/Jun/20 17:09
Worklog Time Spent: 10m
Work Description: vikrambohra opened a new pull request #3028:
URL: https://github.com/apache/incubator-gobblin/pull/3028
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1181
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
'org.apache.parquet:parquet-protobuf:1.10.1' is not resolvable from
MavenCentral because it's missing some of its transitive dependencies. This
will cause 'gobblin-apache-parquet' module also not be resolvable from Central
(in the future, when it will be published to Central). To fix this, I suggest
using 'compileOnly'. This will ensure that 'gobblin-parquet-apache' is cleanly
resolvable from Central.
This change unblocks automated consumption of gobblin external artifact at
LinkedIn
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested by running the build and inspecting the pom files
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 441421)
Time Spent: 40m (was: 0.5h)
> Make parquet-proto dependency in gobblin-parquet-apache compileOnly
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1181
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1181
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> 'org.apache.parquet:parquet-protobuf:1.10.1' is not resolvable from
> MavenCentral because it's missing some of its transitive dependencies. This
> will cause 'gobblin-apache-parquet' module _also not be resolvable_ from
> Central (in the future, when it will be published to Central). To fix this, I
> suggest using 'compileOnly'. This will ensure that 'gobblin-parquet-apache'
> is cleanly resolvable from Central.
> This change unblocks automated consumption of gobblin external artifact at
> LinkedIn
> Tested by running the build and inspecting the pom files
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
