[
https://issues.apache.org/jira/browse/GOBBLIN-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hung Tran resolved GOBBLIN-1186.
--------------------------------
Fix Version/s: 0.15.0
Resolution: Fixed
Issue resolved by pull request #3034
[https://github.com/apache/incubator-gobblin/pull/3034]
> Fix SFDC source.querybased.salesforce.is.soft.deletes.pull.disabled not
> available for simple mode
> -------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1186
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1186
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Alex Li
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> *Problem statement*
> source.querybased.salesforce.is.soft.deletes.pull.disabled
> doesn’t work for simple mode, it works only for dynamic mode.
> the reason is - we explicitly set up the key-value for the dynamic mode
> [https://github.com/hanghangliu/gobblin/blob/9029a89b85ef373f78d603b14d6aaa75998f3356/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java#L327]
>
> *Root cause*
> The extract state is blank(please see code)
> What we set up in job file is not able to see in extractor state.
> [https://github.com/hashdoop/hashdoop-incubator-gobblin/blob/a871e5c5d6f539bcfbcc4e2850685c58dd72dd1a/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/QueryBasedSource.java#L234]
>
> *Solution:*
> explicitly set up the {{soft.deletes.pull.disabled}} for simple mode, as we
> did for dynamic mode
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
