[
https://issues.apache.org/jira/browse/GOBBLIN-1189?focusedWorklogId=443932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443932
]
ASF GitHub Bot logged work on GOBBLIN-1189:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 19:22
Start Date: 10/Jun/20 19:22
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3037:
URL:
https://github.com/apache/incubator-gobblin/pull/3037#issuecomment-642202882
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=h1)
Report
> Merging
[#3037](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc)
will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3037 +/- ##
=========================================
Coverage 45.66% 45.67%
- Complexity 9296 9298 +2
=========================================
Files 1956 1956
Lines 74397 74402 +5
Branches 8247 8247
=========================================
+ Hits 33977 33984 +7
Misses 37242 37242
+ Partials 3178 3176 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...actor/extract/kafka/KafkaIngestionHealthCheck.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUluZ2VzdGlvbkhlYWx0aENoZWNrLmphdmE=)
| `84.21% <100.00%> (ø)` | `13.00 <0.00> (ø)` | |
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| `43.68% <0.00%> (-5.83%)` | `10.00% <0.00%> (-2.00%)` | |
|
[...apache/gobblin/salesforce/QueryResultIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUXVlcnlSZXN1bHRJdGVyYXRvci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[...che/gobblin/salesforce/ResultChainingIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUmVzdWx0Q2hhaW5pbmdJdGVyYXRvci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.03% <0.00%> (+0.33%)` | `33.00% <0.00%> (ø%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.56% <0.00%> (+0.66%)` | `25.00% <0.00%> (+1.00%)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
|
[...rg/apache/gobblin/salesforce/SalesforceSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh)
| `20.83% <0.00%> (+1.01%)` | `13.00% <0.00%> (+1.00%)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `60.60% <0.00%> (+1.51%)` | `15.00% <0.00%> (+1.00%)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3037/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `40.47% <0.00%> (+3.17%)` | `16.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=footer).
Last update
[31f2ef1...75d37c4](https://codecov.io/gh/apache/incubator-gobblin/pull/3037?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 443932)
Time Spent: 20m (was: 10m)
> Relax the condition for the increasing ingestion latency check
> --------------------------------------------------------------
>
> Key: GOBBLIN-1189
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1189
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The increasing latency check in KafkaIngestionHealthCheck checks for the
> latency to be strictly increasing i.e current latency > previous latency.
> This task relaxes the condition to: current latency >= previous latency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
