ZihanLi58 commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439080847
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java
##########
@@ -88,33 +94,43 @@
public DatasetCleaner(FileSystem fs, Properties props) throws IOException {
- State state = new State(props);
+ Properties properties = new Properties();
+ properties.putAll(props);
+ // load dynamic configuration and add them to the job properties
+ Config propsAsConfig = ConfigUtils.propertiesToConfig(props);
+ DynamicConfigGenerator dynamicConfigGenerator =
+
DynamicConfigGeneratorFactory.createDynamicConfigGenerator(propsAsConfig);
+ Config dynamicConfig =
dynamicConfigGenerator.generateDynamicConfig(propsAsConfig);
+ for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
+ properties.put(entry.getKey(), entry.getValue().unwrapped().toString());
Review comment:
It was working well magically... But I change the code to avoid confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
