[
https://issues.apache.org/jira/browse/GOBBLIN-1185?focusedWorklogId=444622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444622
]
ASF GitHub Bot logged work on GOBBLIN-1185:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 23:32
Start Date: 11/Jun/20 23:32
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439125481
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/CleanableDatasetBase.java
##########
@@ -122,6 +122,6 @@ public CleanableDatasetBase(FileSystem fs, Properties
properties, boolean simula
@Override
public List<VersionFinderAndPolicy<T>> getVersionFindersAndPolicies() {
return ImmutableList
- .<VersionFinderAndPolicy<T>> of(new
VersionFinderAndPolicy<>(getRetentionPolicy(), getVersionFinder()));
+ .<VersionFinderAndPolicy<T>> of(new
VersionFinderAndPolicy<>(getRetentionPolicy(), getVersionFinder(), null));
Review comment:
Shall we change it to ConfigFactory.empty() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 444622)
Time Spent: 1h 20m (was: 1h 10m)
> Enable dataset cleaner to emit kafka events
> -------------------------------------------
>
> Key: GOBBLIN-1185
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1185
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
