[
https://issues.apache.org/jira/browse/GOBBLIN-1191?focusedWorklogId=445165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445165
]
ASF GitHub Bot logged work on GOBBLIN-1191:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/20 21:11
Start Date: 12/Jun/20 21:11
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3039:
URL:
https://github.com/apache/incubator-gobblin/pull/3039#issuecomment-643484827
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=h1)
Report
> Merging
[#3039](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/8b9744e21f9bfb7ff2d01391eed28bb0b8799b33&el=desc)
will **increase** coverage by `36.52%`.
> The diff coverage is `6.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3039 +/- ##
=============================================
+ Coverage 9.27% 45.80% +36.52%
- Complexity 1695 9333 +7638
=============================================
Files 1956 1956
Lines 74402 74423 +21
Branches 8247 8250 +3
=============================================
+ Hits 6903 34086 +27183
+ Misses 66826 37145 -29681
- Partials 673 3192 +2519
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `14.73% <6.66%> (+14.73%)` | `4.00 <0.00> (+4.00)` | |
|
[.../org/apache/gobblin/writer/AvroHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9BdnJvSGRmc0RhdGFXcml0ZXIuamF2YQ==)
| `77.77% <0.00%> (ø)` | `5.00% <0.00%> (+1.00%)` | |
|
[...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `2.00% <0.00%> (+2.00%)` | |
|
[...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh)
| `0.94% <0.00%> (+0.94%)` | `1.00% <0.00%> (+1.00%)` | |
|
[...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=)
| `81.97% <0.00%> (+1.16%)` | `32.00% <0.00%> (ø%)` | |
|
[...in/java/org/apache/gobblin/util/FileListUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZUxpc3RVdGlscy5qYXZh)
| `71.42% <0.00%> (+1.29%)` | `28.00% <0.00%> (ø%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.03% <0.00%> (+1.32%)` | `33.00% <0.00%> (+1.00%)` | |
|
[...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh)
| `1.34% <0.00%> (+1.34%)` | `1.00% <0.00%> (+1.00%)` | |
|
[...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==)
| `83.60% <0.00%> (+1.63%)` | `9.00% <0.00%> (+1.00%)` | |
| ... and [1029
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3039/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=footer).
Last update
[8b9744e...86f58fc](https://codecov.io/gh/apache/incubator-gobblin/pull/3039?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 445165)
Time Spent: 50m (was: 40m)
> Reuse Helix instance names when containers are released by Gobblin
> Application Master
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1191
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1191
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-yarn
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, when containers are released by Gobblin Application Master, the
> Helix instance names are not released back to the pool of unused instance
> names. The effect of this is that the number of unique Helix instances keeps
> growing over time. Since Helix creates one znode per instance, this can
> result in the number of znodes to grow unboundedly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
