[
https://issues.apache.org/jira/browse/GOBBLIN-1193?focusedWorklogId=445970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445970
]
ASF GitHub Bot logged work on GOBBLIN-1193:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/20 17:48
Start Date: 15/Jun/20 17:48
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3041:
URL: https://github.com/apache/incubator-gobblin/pull/3041#discussion_r440344028
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractorStatsTracker.java
##########
@@ -327,19 +327,30 @@ private void updateAggregateExtractorStats(int
partitionIdx) {
if (partitionStats.getStopFetchEpochTime() >
aggregateExtractorStats.getMaxStopFetchEpochTime()) {
aggregateExtractorStats.setMaxStopFetchEpochTime(partitionStats.getStopFetchEpochTime());
}
- long partitionLatency = partitionStats.getStopFetchEpochTime() -
partitionStats.getMinLogAppendTime();
+
+ long partitionLatency = 0L;
+ if (partitionStats.getMinLogAppendTime() > 0) {
Review comment:
Javadoc for it indicating no records?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 445970)
Time Spent: 1h 50m (was: 1h 40m)
> Ensure that ingestion latency is 0 when no records are consumed by Kafka
> Extractor
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1193
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1193
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> When no records are consumed by Kafka Extractor during an epoch,
> KafkaExtractorStatsTracker incorrectly returns a non-zero value for ingestion
> latency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
