arjun4084346 commented on a change in pull request #3042:
URL: https://github.com/apache/incubator-gobblin/pull/3042#discussion_r440908142
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -269,23 +270,40 @@ public boolean exists(URI uri) {
}
@Override
- public Spec getSpec(URI uri) throws SpecNotFoundException {
+ public Spec getSpecs(URI uri) throws SpecNotFoundException {
try {
return specStore.getSpec(uri);
} catch (IOException e) {
throw new RuntimeException("Cannot retrieve Spec from Spec store for
URI: " + uri, e);
}
}
+ @Override
+ public Collection<Spec> getSpecs(SpecSearchObject specSearchObject) {
+ try {
+ return specStore.getSpecs(specSearchObject);
+ } catch (IOException e) {
+ throw new RuntimeException("Cannot retrieve Spec from Spec store for
URI: " + specSearchObject, e);
+ }
+ }
+
+ public Collection<Spec> getAllSpecs() {
+ try {
+ return specStore.getSpecs();
Review comment:
Yes, good consideration. Also need to pay attention if slave nodes also
have all the specs in their memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
