[ 
https://issues.apache.org/jira/browse/GOBBLIN-1196?focusedWorklogId=446555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446555
 ]

ASF GitHub Bot logged work on GOBBLIN-1196:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/20 14:45
            Start Date: 16/Jun/20 14:45
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on a change in pull request 
#3042:
URL: https://github.com/apache/incubator-gobblin/pull/3042#discussion_r440908142



##########
File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -269,23 +270,40 @@ public boolean exists(URI uri) {
   }
 
   @Override
-  public Spec getSpec(URI uri) throws SpecNotFoundException {
+  public Spec getSpecs(URI uri) throws SpecNotFoundException {
     try {
       return specStore.getSpec(uri);
     } catch (IOException e) {
       throw new RuntimeException("Cannot retrieve Spec from Spec store for 
URI: " + uri, e);
     }
   }
 
+  @Override
+  public Collection<Spec> getSpecs(SpecSearchObject specSearchObject) {
+    try {
+      return specStore.getSpecs(specSearchObject);
+    } catch (IOException e) {
+      throw new RuntimeException("Cannot retrieve Spec from Spec store for 
URI: " + specSearchObject, e);
+    }
+  }
+
+  public Collection<Spec> getAllSpecs() {
+    try {
+      return specStore.getSpecs();

Review comment:
       Yes, good consideration. Also need to pay attention if slave nodes also 
have all the specs in their memory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 446555)
    Time Spent: 40m  (was: 0.5h)

> add support to search flow configs using multiple configs and other params
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1196
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1196
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to