arjun4084346 commented on a change in pull request #3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r443074977



##########
File path: 
gobblin-modules/gobblin-kafka-09/src/main/java/org/apache/gobblin/kafka/writer/Kafka09DataWriter.java
##########
@@ -84,6 +83,7 @@ public long bytesWritten() {
       };
 
   private final Producer<K, V> producer;
+  @EqualsAndHashCode.Include

Review comment:
       We instantiate different executors(producers) for different kafka topics 
to send specs to. So I found only topic name to be relevant in comparing 
producers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to