[
https://issues.apache.org/jira/browse/GOBBLIN-1203?focusedWorklogId=449947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449947
]
ASF GitHub Bot logged work on GOBBLIN-1203:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/20 18:07
Start Date: 23/Jun/20 18:07
Worklog Time Spent: 10m
Work Description: aryavaibhav93 commented on a change in pull request
#3050:
URL: https://github.com/apache/incubator-gobblin/pull/3050#discussion_r444412834
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
##########
@@ -140,9 +140,13 @@ public FileAwareInputStreamDataWriter(State state, int
numBranches, int branchId
this.fs = FileSystem.get(uri, conf);
this.fileContext = FileContext.getFileContext(uri, conf);
- this.stagingDir = this.writerAttemptIdOptional.isPresent() ? WriterUtils
- .getWriterStagingDir(state, numBranches, branchId,
this.writerAttemptIdOptional.get())
- : WriterUtils.getWriterStagingDir(state, numBranches, branchId);
+ if
(state.getPropAsBoolean(ConfigurationKeys.USER_DEFINED_STAGING_DIR_FLAG)) {
Review comment:
For backward-compatibility, I have added default value of
USER_DEFINED_STAGING_DIR_FLAG as false, also, in disctp template the value for
the above flag is false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 449947)
Time Spent: 20m (was: 10m)
> Adding configuration for user-specified static staging directory
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1203
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1203
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
