[
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453107
]
ASF GitHub Bot logged work on GOBBLIN-1207:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/20 20:55
Start Date: 30/Jun/20 20:55
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447928386
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##########
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {
Review comment:
The intention in this file doesn't seem to be right. Can you fix it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 453107)
Time Spent: 20m (was: 10m)
> Clear references to large objects in Fork, FileBasedExtractor, and
> HiveWritableHdfsDataWriter
> ---------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain
> references to objects that can be large, such as ORC reader and writer
> buffers. Clear these references to allow the memory to be reclaimed during
> the job execution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
