sv2000 commented on a change in pull request #3056:
URL: https://github.com/apache/incubator-gobblin/pull/3056#discussion_r453916541
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
##########
@@ -142,23 +142,25 @@
public GobblinClusterManager(String clusterName, String applicationId,
Config sysConfig,
Optional<Path> appWorkDirOptional) throws Exception {
+ // Set system properties passed in via application config. As an example,
Helix uses System#getProperty() for ZK configuration
+ // overrides such as sessionTimeout. In this case, the overrides specified
+ // in the application configuration have to be extracted and set before
initializing HelixManager.
+ GobblinClusterUtils.setSystemProperties(sysConfig);
+
+ //Add dynamic config
+ this.config = GobblinClusterUtils.addDynamicConfig(sysConfig);
Review comment:
Yes. Dynamic config generation should happen after system properties are
set, since some of the config generation (such as temp file locations) depend
on system properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
