[
https://issues.apache.org/jira/browse/GOBBLIN-1211?focusedWorklogId=458396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458396
]
ASF GitHub Bot logged work on GOBBLIN-1211:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/20 00:46
Start Date: 14/Jul/20 00:46
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3059:
URL: https://github.com/apache/incubator-gobblin/pull/3059
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1211
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
The AMRMClient processes container allocation events asynchronously in a
separate thread. If there are multiple concurrent container requests and
consequent callbacks, we need to ensure that updates to shared data structures
such as the set of unused Helix instance names are consistent and thread-safe.
In other words, any updates to this set made by one thread will be visible to
all other threads handling the container allocation events.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Existing tests.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 458396)
Remaining Estimate: 0h
Time Spent: 10m
> Track unused Helix instances in a thread-safe manner
> ----------------------------------------------------
>
> Key: GOBBLIN-1211
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1211
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-yarn
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The AMRMClient processes container allocation events asynchronously in a
> separate thread. If there are multiple concurrent container requests and
> consequent callbacks, we need to ensure that updates to shared data
> structures such as the set of unused Helix instance names are consistent and
> thread-safe. In other words, any updates to this set made by one thread will
> be visible to all other threads handling the container allocation events.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
