[ 
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=458874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458874
 ]

ASF GitHub Bot logged work on GOBBLIN-1210:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/20 18:47
            Start Date: 14/Jul/20 18:47
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r454569680



##########
File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##########
@@ -229,6 +227,8 @@ public static void main(String[] args) throws Exception {
         printUsage(options);
         System.exit(1);
       }
+      Config config = ConfigFactory.load();

Review comment:
       Also it would be good to add a comment explaining why the token update 
is done in the main() i.e "Because AM is restarted with the original 
AppSubmissionContext, it may have outdated delegation tokens. So the refreshed 
tokens should be added into the container's UGI before any HDFS/Hive/RM access 
is performed."  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 458874)
    Time Spent: 1h  (was: 50m)

> Force AM to read from token file to update token when start up
> --------------------------------------------------------------
>
>                 Key: GOBBLIN-1210
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to