[
https://issues.apache.org/jira/browse/GOBBLIN-1212?focusedWorklogId=459506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459506
]
ASF GitHub Bot logged work on GOBBLIN-1212:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/20 19:51
Start Date: 15/Jul/20 19:51
Worklog Time Spent: 10m
Work Description: autumnust opened a new pull request #3060:
URL: https://github.com/apache/incubator-gobblin/pull/3060
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1212
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Before this change, the handling for non-primitive types like map,array and
union will hit NPE since they don't have `fieldNames`. This fixed that and
making sure the eligibility check happens recursively into those types.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 459506)
Remaining Estimate: 0h
Time Spent: 10m
> Handle shuffle-key eligibility check properly
> ----------------------------------------------
>
> Key: GOBBLIN-1212
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1212
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
