[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3060: [GOBBLIN-1212] Handle non-Primitive type eligibility-check for shuffle key properly

[GitBox]

autumnust commented on a change in pull request #3060:
URL: https://github.com/apache/incubator-gobblin/pull/3060#discussion_r455417617



##########
File path: 
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcUtils.java
##########
@@ -491,18 +491,34 @@ public static WritableComparable 
createValueRecursively(TypeDescription schema)
    */
   public static boolean eligibleForUpConvertHelper(TypeDescription 
originalSchema, TypeDescription targetSchema) {
     if (!targetSchema.getCategory().isPrimitive()) {
-      if 
(!originalSchema.getFieldNames().containsAll(targetSchema.getFieldNames())) {
-        return false;
-      }
-      boolean result = true;
+      if (targetSchema.getCategory().equals(TypeDescription.Category.LIST)) {
+        return eligibleForUpConvertHelper(originalSchema.getChildren().get(0), 
targetSchema.getChildren().get(0));

Review comment:
       Will add a safety-guard. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org