[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #3065: [GOBBLIN-1217] start metrics reporting with a few map-reduce properties

[GitBox]

jack-moseley commented on a change in pull request #3065:
URL: https://github.com/apache/incubator-gobblin/pull/3065#discussion_r457895558



##########
File path: 
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
##########
@@ -367,6 +374,20 @@ public void startMetricReportingWithFileSuffix(State 
state, String metricsFileSu
       oldMetricsFileSuffix += "." + metricsFileSuffix;
     }
     metricsReportingProps.setProperty(ConfigurationKeys.METRICS_FILE_SUFFIX, 
oldMetricsFileSuffix);
+
+    if (!Strings.isNullOrEmpty(metricsFileSuffix)) {
+      String[] tokens = metricsFileSuffix.split("_");

Review comment:
       I just googled and found that there are mapreduce classes for these such 
as `TaskAttemptID`. Would it be possible to make use of these to get the 
properties through APIs instead of parsing the string manually?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org