[
https://issues.apache.org/jira/browse/GOBBLIN-1217?focusedWorklogId=461438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461438
]
ASF GitHub Bot logged work on GOBBLIN-1217:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/20 07:34
Start Date: 21/Jul/20 07:34
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3065:
URL: https://github.com/apache/incubator-gobblin/pull/3065#discussion_r457895558
##########
File path:
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/GobblinMetrics.java
##########
@@ -367,6 +374,20 @@ public void startMetricReportingWithFileSuffix(State
state, String metricsFileSu
oldMetricsFileSuffix += "." + metricsFileSuffix;
}
metricsReportingProps.setProperty(ConfigurationKeys.METRICS_FILE_SUFFIX,
oldMetricsFileSuffix);
+
+ if (!Strings.isNullOrEmpty(metricsFileSuffix)) {
+ String[] tokens = metricsFileSuffix.split("_");
Review comment:
I just googled and found that there are mapreduce classes for these such
as `TaskAttemptID`. Would it be possible to make use of these to get the
properties through APIs instead of parsing the string manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461438)
Time Spent: 0.5h (was: 20m)
> add a few map/reduce task related configs in building metric reporter
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1217
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1217
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> one of the use case can be that each mapper/reducer's metrics can be analyzed
> separately
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
