[
https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274289#comment-13274289
]
Ferdy Galema commented on GORA-126:
-----------------------------------
I have not yet added tests for the new functionality. Tests I have done include
an integrated test with Nutch, specifically NUTCH-1365 and with the HBaseStore.
(But I tried to make it work with the other store implementation in mind too:
The patch does not change HBaseStore specifics). Existing functionality should
not be affected. Note that some aspects did not work anyway such as changing
Properties in runtime.
I like to hear if this is the right direction to go. Maybe you think
deprecating the entire DataStoreFactory is unnecessary, or perhaps you do not
want to deprecate Properties at all? Do we need preferredSchemaName? Stuff like
this would be useful feedback.
When there is some consensus on this I will add tests later on.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this
> issue for future reference. Generally speaking this issue should move towards
> an adoption of Configuration (as this is the de facto implementation within
> the Hadoop ecosystem of products) object rather than the gora specific
> Properties object for defining datastore configuration specifics.
> [0]
> http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
