[ 
https://issues.apache.org/jira/browse/GORA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424915#comment-13424915
 ] 

Ferdy Galema commented on GORA-162:
-----------------------------------

+1. Agree with 2 space indents. Of all formatting this is the most important 
one rule. I'm not sure how your template can actually be used/imported by 
eclipse.  It is a big file with lots of formatting options. (At least you might 
want to change the name to Gora, instead of Nutch). I just set my workspace to 
globally have all projects to use 2 space indents. That usually covers all.

In any case, I do not opt for a single all-changing reformatting commit, as 
this always gives a lot of merger headaches for other issues with existing 
patches. Code should be reformatted when it is subject to actual change.
                
> Format code in Gora
> -------------------
>
>                 Key: GORA-162
>                 URL: https://issues.apache.org/jira/browse/GORA-162
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 0.2.1
>            Reporter: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 0.3
>
>
> Hi All,
> From previous conversations with Enis I think the codeformatting for Gora 
> should be 2 space indents... is this correct?
> This is 'meant' to be the same over in Nutchland. For reference I have a link 
> to an eclipse file [0] which you can load into your workspace. I'm also going 
> to commit this to trunk for future reference and for the larger patches which 
> we will have coming up.
> [0] https://svn.apache.org/repos/asf/nutch/branches/2.x/eclipse-codeformat.xml

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to