[ 
https://issues.apache.org/jira/browse/GORA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609723#comment-13609723
 ] 

Lewis John McGibbney commented on GORA-174:
-------------------------------------------

This Alfonso. Great work on the patches. I wish I earned as much as the boss ;)
I think the full patches are pretty difficult to absorb given that not all of 
the patch will be integrated when the commit is made. 
Is it possible for patches (which for these issues will be applied against 
GORA_174 branch) to only include what you intend to commit for one particular 
commit as oppose to the entire proposal in one patch.
For example, if I am not mistaken the new patches for this issue and GORA-207 
both include the entire issue patch as oppose to just the parts you wish to add 
on for each commit.
Does this make sense? I hope I have explained properly. 
                
> GORA compiler does not handle ["string", "null"] unions in the AVRO schema
> --------------------------------------------------------------------------
>
>                 Key: GORA-174
>                 URL: https://issues.apache.org/jira/browse/GORA-174
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: schema
>    Affects Versions: 0.2.1
>            Reporter: Julien Nioche
>            Assignee: Alfonso Nishikawa
>            Priority: Blocker
>             Fix For: 0.3
>
>         Attachments: GORA-174.patch, GORA-174.patch, GORA-174.patch, 
> GORA-174.patch, GORA-174-test.patch
>
>
> See NUTCH-1477 for description. 
> We are getting NPE when using the DataFileAvroStore, in order to avoid that I 
> modified the schema to allow for null values on some fields e.g.    {"name": 
> "baseUrl", "type": ["string", "null"] }
> however when generating the code for the schema the accessors are not 
> generated by GORA which prevents Nutch from compiling 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to