[
https://issues.apache.org/jira/browse/GORA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731439#comment-13731439
]
Renato Javier Marroquín Mogrovejo commented on GORA-264:
--------------------------------------------------------
I think this looks great Apos! Thank you so very much for this! (:
There is just one little thing, but that is because I am annoying. On the
_ALL_FIELDS array declaration, you can see that at the end of the array an
extra comma gets in there. In spite of the fact that doesn't cause any
problems, it shouldn't be there.
public static final String[] _ALL_FIELDS =
{"url","content","parsedContent","outlinks","metadata",};
And so does in the enum "Field" declaration:
public static enum Field {
URL(0,"url"),
CONTENT(1,"content"),
PARSED_CONTENT(2,"parsedContent"),
OUTLINKS(3,"outlinks"),
METADATA(4,"metadata"),
;
Do you guys want to fix this in here? or maybe opening another JIRA issue for
this?
> Make generated data beans more java doc friendly
> ------------------------------------------------
>
> Key: GORA-264
> URL: https://issues.apache.org/jira/browse/GORA-264
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Reporter: Renato Javier Marroquín Mogrovejo
> Assignee: Apostolos Giannakidis
> Priority: Minor
> Fix For: 0.4
>
> Attachments: Employee.java, GORA-264.patch, GORA-264v2.patch,
> GORA-264v3.patch, GVertex.java, Metadata.java, TokenDatum.java, vertex.json,
> vertex.json, WebPage.java
>
>
> Generating code through our Gora Compiler is in pretty good shape but our
> generated data beans are not so good looking as they don't have any java doc
> in them. As we are already generating the whole code, I think we could add
> some java doc to make them look better.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
