[ 
https://issues.apache.org/jira/browse/GORA-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apostolos Giannakidis updated GORA-231:
---------------------------------------

    Attachment: GORA-231v2.patch

Lewis, I created another patch for this issue. This patch changes the 
DataStoreFactory.getMappingFile() and adds inside it a check that the file 
exists. If not it throws an IOException with an informative message.

As far as I saw, only 2 datastores use the method 
DataStoreFactory.getMappingFile(). These are the gora-accumulo and gora-solr. 
Gora-Accumulo already catches the IOException, so there was no need to change 
this store. However, Gora-Solr was not catching the IOException, so I changed 
the store accordingly. This change is also included in the patch.
                
> Provide better error handling in AccumuloStore.readMapping when file does not 
> exist.
> ------------------------------------------------------------------------------------
>
>                 Key: GORA-231
>                 URL: https://issues.apache.org/jira/browse/GORA-231
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-accumulo
>    Affects Versions: 0.3
>            Reporter: David Medinets
>            Assignee: Apostolos Giannakidis
>             Fix For: 0.4
>
>         Attachments: GORA-231.patch, GORA-231v2.patch
>
>
> When the filename does not exist, the error message is 
> "java.lang.IllegalArgumentException: InputStream cannot be null". The error 
> message should be more specific like "IOException; unable to open 
> gora-accumulo-mapping.xml".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to