[ 
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805363#comment-13805363
 ] 

Lewis John McGibbney commented on GORA-94:
------------------------------------------

Hi Yasin, thanks for this. Great work. Glad to see that you've moved on 
considerably with your use of Gora.
I have some comments:
* The way that the patch has been created means I cannot apply it locally to my 
checkout of GORA_94 branch. If you are in $GORA_HOME then you can generate a 
patch simply by doing svn diff > myBeautifulPatch.patch or if you are in git, 
then please do git diff --no-prefix > myBeautifulPatch.patch 
* The patch seems to combine numerous things which are not useful at this 
point. For example, it includes a bunch of MANIFEST information as well as 
pom.xml configuration to suit. This is not required for the Avro upgrade.
* Is it possible for us to upgrade ONLY Avro with this umbrella issue? Is it 
absolutely required that an upgrade of HBase happens at the same time? I was 
hoping that this would not be the case but can live with it if it is.

If we can begin with the above then we can move on. 
Finally, did you get a chance to look at the most recent code for the GORA-94 
branch? AFAIK the Avro upgrade for gora-core is nearly complete with only one 
failing test e.g. testSerdeMultipleWebPages

Again, thanks for your contributions. People like yourself pushing this forward 
is exactly what we require here.

> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.4
>
>         Attachments: GORA-94.patch, GORA-94-v2.patch, GORA-94-v3.patch, 
> GORA-94-v4.patch, GORA_94v5.patch, GORA-94v6.diff, GORA-94v7.patch, 
> GORA-94v8.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that 
> it's going to be some reasonably major work...  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to