[ 
https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney updated GORA-246:
--------------------------------------

    Attachment: GORA-246v3.patch

Patch attached 
* upgrades HBase to 0.94.13 (however please note we still use some deprecated 
classes in one or two classes.)
* Corrects PersistentBase#checkIfMutableFieldAndDirty ARRAY and UNION switch 
blocks... this avoides ClassCastException in testPutNested however I think this 
now duplicates code and can be further improved.
* Makes changes to HBaseStore#put regarding switch statements... please check 
this out.

Whilst I was debugging TestHBaseStore#testPutArray and consequently the 
@Override method #assertPutArray I am left with an assettion error saying that 
the 4 tokens in the array should be present however we have 0. As I debugged 
the test again, I see that within HBaseStore#put when we switch to ARRAY for 
parsedContent field in WebPage it seems that the array is NOT an instance of 
Avro GenericArray... this therefore means that we break and do not add the 
array as a dirty field.

This is as far as I've got with this issue right now and will unfortunately not 
be able to work with it until Monday as I am going away from my beloved Linux 
for the weekend ;)  

> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
>                 Key: GORA-246
>                 URL: https://issues.apache.org/jira/browse/GORA-246
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: gora-core, gora-hbase
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 0.4
>
>         Attachments: GORA-246.patch, GORA-246v2.patch, GORA-246v3.patch, 
> GORA_246.HBaseDriverTest.patch, GORA_246.HBaseDriverTest.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to