[
https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937548#comment-13937548
]
Alparslan Avcı edited comment on GORA-246 at 3/17/14 8:36 AM:
--------------------------------------------------------------
Hi [~hsaputra],
First of all, you can assign this task to me. No problem for me. And thanks
[~renato2099] for the patches.
About the recent patches, I want to comment to some points.
# In the [^GORA-246.FailingTest.patch], we do not need to check if the
_qualifier_ parameter is null or not at _case MAP_ in
_HBaseStore.addPutsAndDeletes()_ method since _qualifier_ is always _null_ in
map case.
# In
[GORA-245.FailingTest.DeleteKey.patch|https://issues.apache.org/jira/secure/attachment/12635005/GORA-245.final.patch],
_DataStoreTestUtil.testUpdateWebPageRemoveMapEntry()_ content has been
changed. With the patch, it removes all of the entries by clearing the map and
puts odd indexed ones again. This was already tested in
_testUpdateWebPagePutToNotNullableMap()_ method. However, the
_testUpdateWebPageRemoveMapEntry()_ method was testing the removal of a single
entry (outlink) in a map by putting _null_ value. I think, this change has to
be reverted.
# IMHO, the sub-issues under GORA-94 umbrella issue must only contain the
changes which are related to the subject of the issue. For instance; in GORA-94
issue, the patches must only contain changes related to all sub issues, like
test cases. And the patches in GORA-245 issue must only contain changes related
to cassandra store. This will make easier for all developers to follow what is
going on.
[~hsaputra], [~renato2099]; wdyt?
was (Author: alparslan.avci):
Hi [~hsaputra],
First of all, you can assign this task to me. No problem for me. And thanks
[~renato2099] for the patches.
About the recent patches, I want to comment to some points.
# In the [^GORA-245.final.patch], we do not need to check if the _qualifier_
parameter is null or not at _case MAP_ in _HBaseStore.addPutsAndDeletes()_
method since _qualifier_ is always _null_ in map case.
# In
[GORA-245.FailingTest.DeleteKey.patch|https://issues.apache.org/jira/secure/attachment/12635005/GORA-245.final.patch],
_DataStoreTestUtil.testUpdateWebPageRemoveMapEntry()_ content has been
changed. With the patch, it removes all of the entries by clearing the map and
puts odd indexed ones again. This was already tested in
_testUpdateWebPagePutToNotNullableMap()_ method. However, the
_testUpdateWebPageRemoveMapEntry()_ method was testing the removal of a single
entry (outlink) in a map by putting _null_ value. I think, this change has to
be reverted.
# IMHO, the sub-issues under GORA-94 umbrella issue must only contain the
changes which are related to the subject of the issue. For instance; in GORA-94
issue, the patches must only contain changes related to all sub issues, like
test cases. And the patches in GORA-245 issue must only contain changes related
to cassandra store. This will make easier for all developers to follow what is
going on.
[~hsaputra], [~renato2099]; wdyt?
> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
> Key: GORA-246
> URL: https://issues.apache.org/jira/browse/GORA-246
> Project: Apache Gora
> Issue Type: Sub-task
> Components: gora-core, gora-hbase
> Affects Versions: 0.4
> Reporter: Lewis John McGibbney
> Fix For: 0.4
>
> Attachments: GORA-246.FailingTest.patch, GORA-246.patch,
> GORA-246v2.patch, GORA-246v3.patch, GORA-246v3.patch, GORA-246v4.patch,
> GORA-246v5.patch, GORA_246.HBaseDriverTest.patch,
> GORA_246.HBaseDriverTest.v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
