[ 
https://issues.apache.org/jira/browse/GORA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968312#comment-13968312
 ] 

Matzz edited comment on GORA-321 at 4/14/14 12:49 PM:
------------------------------------------------------

What is more, GoraCompiler 
(http://svn.apache.org/repos/asf/gora/trunk/gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java)
 outputs following imports
{code}

    line(0, "import java.nio.ByteBuffer;");
    line(0, "import java.util.Map;");
    line(0, "import java.util.HashMap;");
    line(0, "import org.apache.avro.Protocol;");
    line(0, "import org.apache.avro.Schema;");
    line(0, "import org.apache.avro.AvroRuntimeException;");
    line(0, "import org.apache.avro.Protocol;");
    line(0, "import org.apache.avro.util.Utf8;");
    line(0, "import org.apache.avro.ipc.AvroRemoteException;");
    line(0, "import org.apache.avro.generic.GenericArray;");
    line(0, "import org.apache.avro.specific.FixedSize;");
    line(0, "import org.apache.avro.specific.SpecificExceptionBase;");
    line(0, "import org.apache.avro.specific.SpecificRecordBase;");
    line(0, "import org.apache.avro.specific.SpecificRecord;");
    line(0, "import org.apache.avro.specific.SpecificFixed;");
    line(0, "import org.apache.gora.persistency.StateManager;");
    line(0, "import org.apache.gora.persistency.impl.PersistentBase;");
    line(0, "import org.apache.gora.persistency.impl.StateManagerImpl;");
    line(0, "import org.apache.gora.persistency.StatefulHashMap;");
    line(0, "import org.apache.gora.persistency.ListGenericArray;");
{code}
Some of those classes are used in compiled code (eg. StateManager) but were 
removed.


was (Author: matzz):
What is more, GoraCompiler 
(http://svn.apache.org/repos/asf/gora/trunk/gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java)
 outputs following imports
{code}

    line(0, "import java.nio.ByteBuffer;");
    line(0, "import java.util.Map;");
    line(0, "import java.util.HashMap;");
    line(0, "import org.apache.avro.Protocol;");
    line(0, "import org.apache.avro.Schema;");
    line(0, "import org.apache.avro.AvroRuntimeException;");
    line(0, "import org.apache.avro.Protocol;");
    line(0, "import org.apache.avro.util.Utf8;");
    line(0, "import org.apache.avro.ipc.AvroRemoteException;");
    line(0, "import org.apache.avro.generic.GenericArray;");
    line(0, "import org.apache.avro.specific.FixedSize;");
    line(0, "import org.apache.avro.specific.SpecificExceptionBase;");
    line(0, "import org.apache.avro.specific.SpecificRecordBase;");
    line(0, "import org.apache.avro.specific.SpecificRecord;");
    line(0, "import org.apache.avro.specific.SpecificFixed;");
    line(0, "import org.apache.gora.persistency.StateManager;");
    line(0, "import org.apache.gora.persistency.impl.PersistentBase;");
    line(0, "import org.apache.gora.persistency.impl.StateManagerImpl;");
    line(0, "import org.apache.gora.persistency.StatefulHashMap;");
    line(0, "import org.apache.gora.persistency.ListGenericArray;");
{code}
Some of those classes (eg. StateManager) were removed.


> Merge GORA_94 into Gora trunk
> -----------------------------
>
>                 Key: GORA-321
>                 URL: https://issues.apache.org/jira/browse/GORA-321
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: avro
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Blocker
>             Fix For: 0.4
>
>         Attachments: GORA-321-final.patch, GORA-321.patch
>
>
> This is a final issue to merge in GORA_94 into trunk.
> I'll get a patch attached here which provides a diff people can apply against 
> Gora trunk code base.
> Within the scope of this patch, I am proposing to NOT release gora-dynamodb 
> for 0.4 as there is additional thought required to get it working.
> [~renato2099] and myself have been discussing this at ApacheCon and will 
> address it in due course.
> I would like to personally thank ALL contributors to GORA_94 branch over 
> recent months. It became a bit of a monster and it a major contribution to 
> Apache Gora. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to