[
https://issues.apache.org/jira/browse/GORA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180691#comment-14180691
]
ASF GitHub Bot commented on GORA-390:
-------------------------------------
GitHub user drazzib opened a pull request:
https://github.com/apache/gora/pull/16
GORA-390 Gora compiler generate wrong isDirtyXXXX method signature
Fix for GORA-390
* Rework generated isXXXDirty methods: remove unneeded _value_ parameter.
* Re-generate all Gora objects from their schemas.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Dictanova/gora GORA-390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit dc5996a5c110ca04e2a641c865f94ffe889f84fb
Author: Damien Raude-Morvan <[email protected]>
Date: 2014-10-22T22:32:08Z
GORA-390 Rework generated isXXXDirty methods.
Remove unneeded _value_ parameter.
commit 80d5d8d1c6f0f24772a1039f8220c679ffca6ea6
Author: Damien Raude-Morvan <[email protected]>
Date: 2014-10-22T22:39:43Z
GORA-390 Re-generate all Gora objects from their schemas.
----
> Gora compiler generate wrong isDirtyXXXX method signature
> ---------------------------------------------------------
>
> Key: GORA-390
> URL: https://issues.apache.org/jira/browse/GORA-390
> Project: Apache Gora
> Issue Type: Bug
> Components: gora-compiler
> Affects Versions: 0.5
> Reporter: Damien Raude-Morvan
> Priority: Minor
>
> Hi,
> I think I've spotted a small issue with actual code generated by
> gora-compiler.
> For each field in source Avro schema, it will generate a isDirtyXXX method
> which have a _value_ parameter which is not really used.
> For instance, for a _content_ field, the following code is generated :
> {code}
> public boolean isContentDirty(java.lang.CharSequence value) {
> return isDirty(6);
> }
> {code}
> I would expect the following code to be generated instead (ie. without value
> parameter) :
> {code}
> public boolean isContentDirty() {
> return isDirty(6);
> }
> {code}
> Regards,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
