Hi Furkan,

On Wed, Aug 26, 2015 at 8:54 PM, <[email protected]> wrote:

>
> I've finished my GSoC project but I have a problem. I've implemented a
> Spark backend for Gora and I've written a word count test class for it.
>

Yep. Nice work.


>
> Here is my particular test method:
>
>
> https://github.com/kamaci/gora/blob/master/gora-hbase/src/test/java/org/apache/gora/hbase/mapreduce/TestHBaseStoreWordCount.java#L65
>

Actually the Test and Method is here
https://github.com/kamaci/gora/blob/master/gora-core/src/examples/java/org/apache/gora/examples/spark/SparkWordCount.java



>
>
> When I run my test there is no need to startup an Hbase cluster because
> Spark will connect to my dummy cluster. However when I run my test method
> it throws an error. Here is a part from stack trace:
>
>
OK, maybe I am interpreting things incorrectly here however unless you want
SparkWordCount.java to be run for every datastore then it should be tested
ONLY by GoraSparkEngine... no?

I need to also comment that I think it is important for you to implement
our base test suite defined within

https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java

and implemented via

https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java

Does this make sense? We need to have the GoraSparkEngine displaying that
it is able to store, operate upon and provide access to all of the test
cases provided under the base test suite.
This is also detailed within our documentation
http://gora.apache.org/current/index.html#gora-testing

If I were you I would implement the Unit tests under
https://github.com/kamaci/gora/tree/master/gora-core/src/test/java/org/apache/gora/spark
or something like that.

[snip]


>
> Any ideas about solving that connection problem?
>

I wouldn't worry about it right now. I would address the questions above
first and tell me/us what you think about that. We can then move on to the
HBase cluster at a later stage.


>
> PS 1: I've ignored the test at my Github repository.
> PS 2: I don't think that there is a problem Spark side.
> PS 3: I'll upload full stack trace to
> https://issues.apache.org/jira/browse/GORA-386
>

Great thank you.
Lewis

Reply via email to