[
https://issues.apache.org/jira/browse/GORA-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729745#comment-14729745
]
ASF GitHub Bot commented on GORA-434:
-------------------------------------
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/38#discussion_r38694058
--- Diff: gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
---
@@ -783,9 +783,7 @@ public void flush() {
@Override
public void close() {
- // In testing, the index gets closed before the commit in flush() can
happen
- // so an exception gets thrown
- // flush();
+ flush();
--- End diff --
Thanks for looking into this @kamaci !
Why don't we wrap this around an exception? so if this happens again while
testing at least we will not just fail but actually try to flush and notify
that something went wrong.
What do you think?
> Documents are Not Committed Into Solr Store
> -------------------------------------------
>
> Key: GORA-434
> URL: https://issues.apache.org/jira/browse/GORA-434
> Project: Apache Gora
> Issue Type: Bug
> Components: gora-solr
> Reporter: Furkan KAMACI
> Fix For: 0.6.1
>
>
> I was testing to write into Solr database and I realized that it doesn't
> commit documents which are at last buffer when buffer is not equal to default
> commit size. For example, run LogAnalytics example with a configuration of
> reading from Hbase and persisting results into Solr. Result size should be
> 3300 but when you check Solr you will see that it is less than it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
