Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/38#discussion_r38694058
--- Diff: gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
---
@@ -783,9 +783,7 @@ public void flush() {
@Override
public void close() {
- // In testing, the index gets closed before the commit in flush() can
happen
- // so an exception gets thrown
- // flush();
+ flush();
--- End diff --
Thanks for looking into this @kamaci !
Why don't we wrap this around an exception? so if this happens again while
testing at least we will not just fail but actually try to flush and notify
that something went wrong.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
