[
https://issues.apache.org/jira/browse/GORA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104112#comment-15104112
]
ASF GitHub Bot commented on GORA-458:
-------------------------------------
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/53#issuecomment-172417033
+1
On Sunday, January 17, 2016, Renato Marroquin <[email protected]>
wrote:
> Closing streams in binaryEncoder.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/gora/pull/53
> Commit Summary
>
> - GORA-458
>
> File Changes
>
> - *M*
>
gora-accumulo/src/main/java/org/apache/gora/accumulo/encoders/BinaryEncoder.java
> <https://github.com/apache/gora/pull/53/files#diff-0> (122)
>
> Patch Links:
>
> - https://github.com/apache/gora/pull/53.patch
> - https://github.com/apache/gora/pull/53.diff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/gora/pull/53>.
>
--
*Lewis*
> DataOutputStream is not closed in BinaryEncoder#encodeXXX() methods
> -------------------------------------------------------------------
>
> Key: GORA-458
> URL: https://issues.apache.org/jira/browse/GORA-458
> Project: Apache Gora
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In
> ./gora-accumulo/src/main/java/org/apache/gora/accumulo/encoders/BinaryEncoder.java
> :
> {code}
> DataOutputStream dos = new DataOutputStream(new
> FixedByteArrayOutputStream(ret));
> dos.writeShort(s);
> return ret;
> {code}
> dos should be closed before returning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
